-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-2404] Replace remaining PF deprecated components #3094
[RHOAIENG-2404] Replace remaining PF deprecated components #3094
Conversation
frontend/src/concepts/roleBinding/RoleBindingPermissionsNameInput.tsx
Outdated
Show resolved
Hide resolved
542de7c
to
253a4ee
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
<div>ALL: {biasMetricConfigs.map((c) => c.name).join(', ')}</div> | ||
<div>UI: {uiSelections}</div> | ||
<div>current: {currentSelections}</div> | ||
<div>initialSelections: {initialSelections.map((s) => s.name).join(', ')}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, not sure how i missed removing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing in #3376
Closes RHOAIENG-2404
Description
Remove use of Patternfly deprecated components
How Has This Been Tested?
Tested manually
Test Impact
The following components are effected:
Request review criteria:
Self checklist (all need to be checked):